Saving strings for the "style sheet" and the "language" preference options #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins |
|
Conflict resolved. Jenkins again |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change the behavior of preferences to save both the "style sheet" and the "language" option as string ( name of the option ), not as integer ( index of the combo box ).
For now, when you introduce a new style or language, an appearance of UI may be unexpectedly changed since the new item is inserted above the current item.
After merging #1332 , I'm going to think that this modification is needed for introducing new style or language safety in the future.
PLEASE NOTE
This PR will reset the language to "English" and the style to "Astral_072_Dark" respectively for the first time you launch the software.