Fix Crash on Setting Negative Frame #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases, the current frame is positive. However, in some rare cases it can be negative such as users manually type the frame number in the console or move the current frame marker in the Function Curves panel.
When the preview mode is activated
Previewertries to obtain the frame status fromstd::vector<UCHAR> Previewer::Imp::m_pbStatus[frame]and for now if the currentframeis negative the returned status becomes undefined and may causes crash.I would like to keep availability of the negative frame itself because there may be a case that the animation key should starts from the negative frame in order to get ”midstream” movement at the first frame.